CI check against prod bundle #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
zurfyx
requested review from
trueadm,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
|
Deployment failed with the following error: |
|
Closes #1631 |
|
As per @trueadm's offline suggestion, I'm reducing the workload while still retaining the runs that give us the most value |
This reverts commit e5b574d.
This reverts commit 8fbf19d50247e70491981d98edad4d0e24e43d57.
This reverts commit da44006f321740ddd3ed2155e636be2aaf45c055.
thegreatercurve
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prod fires prevention
It happened once and just happened twice. We build and thoroughly test our dev bundle only to find that our prod bundle is completely flawed and can potentially crash the entire site.
The best way to mitigate this is by extending our test suite to test with our production bundle as well as dev. My hunch is that we don't need to test the entire matrix like we do for dev but we should at least test one browser + collab, this should already give us some good confidence in that the prod bundle is behaving just as well as the dev one.